Discussion Thread for Price Check
- Thread starter mycroft
- Start date
Pygar
EQ2Bot Specialist
My recomendation for improvement:
I would add some logic to undercutting the base price. Basically determine the mean price an item is selling for, and do not adjust automatically to anything that is priced 30% under mean price. It wont be hard for me to identify someone running this script and potentially exploit it. General rule of thumb is anything under 30% of mean will sell too fast, and you'll make more not cutting to it.
Secondly, I would MUCH prefer adjusting to MATCH the lowest price, not undercutting it, as when 15 people on my server run this script, we're just going to spiral the value down to our floor price anyway...
I would add some logic to undercutting the base price. Basically determine the mean price an item is selling for, and do not adjust automatically to anything that is priced 30% under mean price. It wont be hard for me to identify someone running this script and potentially exploit it. General rule of thumb is anything under 30% of mean will sell too fast, and you'll make more not cutting to it.
Secondly, I would MUCH prefer adjusting to MATCH the lowest price, not undercutting it, as when 15 people on my server run this script, we're just going to spiral the value down to our floor price anyway...
Heh I think we all have planned out this script but glad to see someone has the time to step up to it. I was waiting for the dll to be released and didn't notice it was till the other day as I was going to do it in .net
The design I was planning on doing was going to be a multi tab for each box, show the item name, current price, what the price would be and then have you either accept it or not.
One issue you may run into though and I will have to look at your script to see if it's addressed but I saw it on Ama's example. Some items when you search for them will also pull up other items that have that as part of their name. When these items are many tier's lower the pricing is a lot cheaper and you end up having to adjust manually.
The design I was planning on doing was going to be a multi tab for each box, show the item name, current price, what the price would be and then have you either accept it or not.
One issue you may run into though and I will have to look at your script to see if it's addressed but I saw it on Ama's example. Some items when you search for them will also pull up other items that have that as part of their name. When these items are many tier's lower the pricing is a lot cheaper and you end up having to adjust manually.
Ah , I didn't think of that , a quick string compare between the name of the item being sold and the item being listed on the broker search should be an easy solution for the wrong item being listed.
In the latest test version of the search routine , I unlist the item I'm selling , find the lowest price , if it's higher than my current price I match the higher price and re-list the item.
In the latest test version of the search routine , I unlist the item I'm selling , find the lowest price , if it's higher than my current price I match the higher price and re-list the item.
Last edited:
Sorry if Im being an idiot, but I never found any documentation on how this works. When I run the script, it just cycles through pages of broker items which all have the word "null" in their title, so Im guessing somethings going wrong. Is there any documentation on how to set this script up out there?
Fixed in the newest version that I'm working on , unfortunately I've been without ISXEQ2 for some days now (Thanks to SoE (/rude) , BIG thank you to Ama for giving us EU peeps a fix).wired203 said:
So I'm still working through a few bugs and the code to set a minimum price for the items that you are selling.
I've uploaded a newer version that should hopefully allow it to be run on any character regardless of allignment.
Last edited:
I haven't checked myprices4 yet as I didn't feel like editing the XML kk I'm lazy lol. On myprices2 to matches to the first name that comes up, say your selling absolution it will pull null absolution which is a much lower spell and use that for pricing instead.
Needs to have a exact text match check to be fully usable but on other things it works great.
Needs to have a exact text match check to be fully usable but on other things it works great.
Hmm...I'm almost sure I did put a check in for an exact match on that..I'll have to check..wired203 said:
This line SHOULD check for N1 (your items name) being an exact match to "${Vendor.Broker[${CurrentItem}]}" (The Broker item being looked at currently) unless I've miss-understood something...
if "${N1.Equal["${Vendor.Broker[${CurrentItem}]}"]}"
Unfortunately everything is on hold again , the EU servers have a different version of the everquest.exe from the US (again)
Last edited:
mycroft said:
'm back....finally all servers have the same Exe...
I tried a small script to check the 'exact' name match using the same code myprices2 uses and it works 100% , I'm not sure why you are having this problem as I can't reproduce it.
*** Update : Just had a brainwave...brb ***
Last edited:
Just had a brainwave....I've uploaded a new version of myprices2 and will upload myprices4 as well as soon as I've made the same changes..
The problem was I was reading the first price of the matched broker list to use as a start point.
But of course...that might not be the correct item name where the names are similar but not exact.
The changes should stop this problem happening now.
The problem was I was reading the first price of the matched broker list to use as a start point.
But of course...that might not be the correct item name where the names are similar but not exact.
The changes should stop this problem happening now.
Last edited:
Sounds great I'll give it a go later this evening and let you know how it's working, only one other comment on the script, for items where you are not changing the value since they match there is nothing echo'd in the console so it appears like it has skipped them when in fact it just didn't have to adjust the value. Might want to add a echo along the lines of "item price already matched for (itemname)"
Thanks again for all of your hard work as well.
Gave it a run during lunch and worked like a charm.
Thanks again for all of your hard work as well.
Gave it a run during lunch and worked like a charm.
Last edited:
Would it be possible to have the script list change the price for all items in your consignment slots instead of just changing the ones currently being sold? This could be useful if you have alot of items to put up at once ( crafting etc) and this way you wouldnt have to do a search and set the price automatically. I tried to get the script to do this by clicking to sell the item without changing the price, but it wouldnt change it because it was always the lowest priced item. Really useful script, keep up the good work Mycroft!
What I do is just list it at a high price when I throw it up, then let it adjust it accordingly. Only issue I have been having is the lag here is kinda high so a lot of times my items wind up unlisted but price matched. Will play with the wait values and see if I can find me a happy setting.
Hmm...yes that is possible...I could add an option to set the price and mark them for sale if an item is unlisted.Algamer said:
Though using the latest version and setting the 'Auto-Match Higher Prices?'' tickbox will do what you ask if the item is listed.
Of course..between you setting it for sale and the script reaching it...could be bought at the cheap price before then 8)
I'll put it on my 'to do' list.
Last edited:
Just posted version 0.06
Added the unlisted item thing as requested.
http://www.isxgames.com/forums/showthread.php?p=11863&posted=1#post11863
Added the unlisted item thing as requested.
http://www.isxgames.com/forums/showthread.php?p=11863&posted=1#post11863
I tried the 0.06 edition last night, appears you implemented the looping and constantly checking pricing. The one issue I see with that is I actually saw what must of been another pricing bot running as my prices on a few items kept decreasing. The issue I see there would be if you had it automated to loop for everyone then you would have to have a XML listing of each item with a bottom price and would hit that bottom price if there is any competition.
Might be best to have pricing set to a single itteration and for looping have people modify that in themselves, but I would definatly put the purchasing up as looped.
Might be best to have pricing set to a single itteration and for looping have people modify that in themselves, but I would definatly put the purchasing up as looped.
There is a minimum price XML file (myprices.xml in your scripts folder) , you have to alter the minimum value by hand once an item has been added automatically by the script.wired203 said:
Version 0.07 (Hoping to have it completed by tonight) will be totally GUI driven.
Oh almost forgot , theres a checkbox for 'continually loop' as well.
Last edited:
Version 0.07
Newest version now up , Totally GUI driven , people using Version 2 to avoid editing setting files by hand, this would be a good time to change over.
http://www.isxgames.com/forums/showthread.php?p=11920#post11920
Newest version now up , Totally GUI driven , people using Version 2 to avoid editing setting files by hand, this would be a good time to change over.
http://www.isxgames.com/forums/showthread.php?p=11920#post11920
Version 0.08
New Version Up : 0.08
http://www.isxgames.com/forums/showthread.php?p=11935#post11935
Updates from 0.09 onwards are going to be sent via the SVN
New Version Up : 0.08
http://www.isxgames.com/forums/showthread.php?p=11935#post11935
Updates from 0.09 onwards are going to be sent via the SVN
Last edited:
Version 0.8d now availble by SVN
Version : 0.08d
---------------
Additional option added :
Each item for sale now can be flagged to check for a minimum price or not , if not flagged then the lowest price on the broker
will always be matched regardless of it's cost.
**** ALL ITEMS when you run this version for the FIRST time will be NOT flagged to check your minimum price ****
**** Go through the list and tick the box against all items you want a minimum price checked and press the save button on each *****
Added additional lag checking code for when the script is setting and un-setting items for sale to try and stop items being left unlisted.
Version : 0.08d
---------------
Additional option added :
Each item for sale now can be flagged to check for a minimum price or not , if not flagged then the lowest price on the broker
will always be matched regardless of it's cost.
**** ALL ITEMS when you run this version for the FIRST time will be NOT flagged to check your minimum price ****
**** Go through the list and tick the box against all items you want a minimum price checked and press the save button on each *****
Added additional lag checking code for when the script is setting and un-setting items for sale to try and stop items being left unlisted.
On items that have a minimum price and show red in the window (Lower price than your minimum price on the broker).
Would people find it useful to have it show how many items on the broker are priced lower than yours?
Buying items:
This is the code walk through for buying items so far.
1. Start at the top of your list
2. Scan the broker for items at or lower than the price you set , keep a record of each price.
3. Sort them in order of price (lowest first)
4. Start buying at the lowest price in batches/singles and reduce the number wanted by the same number.
5. Move onto the next person selling the item and do step 4 until there are no more items on the broker at
or lower than the price you set or you have bought the number of them set.
6. Move onto the next item in your list and go back to step 2.
Have I missed anything out?
The logic is a lot more complicated than the selling code so it's taking me longer to code , plus I have to be sure you don't go and buy 2000 raws you didn't want at 10g each if I make a mistake and the script goes wrong 8)
Would people find it useful to have it show how many items on the broker are priced lower than yours?
Buying items:
This is the code walk through for buying items so far.
1. Start at the top of your list
2. Scan the broker for items at or lower than the price you set , keep a record of each price.
3. Sort them in order of price (lowest first)
4. Start buying at the lowest price in batches/singles and reduce the number wanted by the same number.
5. Move onto the next person selling the item and do step 4 until there are no more items on the broker at
or lower than the price you set or you have bought the number of them set.
6. Move onto the next item in your list and go back to step 2.
Have I missed anything out?
The logic is a lot more complicated than the selling code so it's taking me longer to code , plus I have to be sure you don't go and buy 2000 raws you didn't want at 10g each if I make a mistake and the script goes wrong 8)
Last edited:
Need a cash counter, so you can set max amount of cash to spend in total. Also I would add in a counter for the items so you only buy say 100 of a item then it sleeps that part because you bought how many you want. But the count would have to be configurable. This way you could set it to buy say a master when it comes in price but not buy 2 of them cause they both are within price.
A nice addition would be a "[ ] PrettyPrice" option to toggle on and off.
Right now, it might set the price to 1pp 44gp 33sp 33cp... Im not really interested in that, hehe - i'd settle with 1pp 44gp... So if you are selling something over 1 plat, it will only set plat and gold, selling something lower than one plat, but N gold, it will cut off the copper, etc...
Making it more realistic prices.
~
Right now, it might set the price to 1pp 44gp 33sp 33cp... Im not really interested in that, hehe - i'd settle with 1pp 44gp... So if you are selling something over 1 plat, it will only set plat and gold, selling something lower than one plat, but N gold, it will cut off the copper, etc...
Making it more realistic prices.
~
I'll add a tickbox to Round Prices , basically it'll just ignore the coppers , if the matching price is 1pp 59g 99s 50c I wouldn't want to lose the 99s 8)Twiddle said:
Edit :
Do you mean the price shown on the broker with broker fee added or the cash you actually get by selling the item?
Last edited:
"Bug" found
I've tracked down what might be happening when some items are left unlisted when it's not due to lag.
When you add items to the consignment system you can either add them so the same items all show as grouped in one slot or seperately.
You can show
Ebon Cluster (2)
or
Ebon Cluster
Ebon Cluster
The script does not have any problems if you the group same items together in your broker list.
The script works by going down your consignment system slot by slot.
If you have 2 items with the same name shown on the broker in the same container but shown as in different broker slots and you change a price , EQ2 changes the order of those items on your broker list.
2 items A and B , totem of the chameleon
1) A - Listed <- script working here
2) B - Listed
A is unlisted , price changed and re-listed
Order is
1) A - Listed <-Script working here
2) B - Listed
B is unlisted , price changed
1) A - Listed
2) B - Unlisted <- script working here
The order is suddenly
1) B - Unlisted
2) A - Listed <- Script working here
The script Lists what it THINKS is the correct item , leaving Item B unlisted.
I've looked into this and there is no way to fix this with the EQ2 system working as it stands.
If the items are different names and the order changes I already check for this and the script re-scans the broker list to get it's data right and stops. (I'm working on a more elegant solution to keep the script scanning)
But with 2 items of the same name I have nothing to compare or check against , there is no unique ID on items in your broker list I can check for.
The 2 ways to currently stop this happening are
1. Always drop items into the broker system so they group up into one slot if they are in the same container.
2. Change the script so it goes through the consignment system and sets everything to Listed after a scan has been done.
I've tracked down what might be happening when some items are left unlisted when it's not due to lag.
When you add items to the consignment system you can either add them so the same items all show as grouped in one slot or seperately.
You can show
Ebon Cluster (2)
or
Ebon Cluster
Ebon Cluster
The script does not have any problems if you the group same items together in your broker list.
The script works by going down your consignment system slot by slot.
If you have 2 items with the same name shown on the broker in the same container but shown as in different broker slots and you change a price , EQ2 changes the order of those items on your broker list.
2 items A and B , totem of the chameleon
1) A - Listed <- script working here
2) B - Listed
A is unlisted , price changed and re-listed
Order is
1) A - Listed <-Script working here
2) B - Listed
B is unlisted , price changed
1) A - Listed
2) B - Unlisted <- script working here
The order is suddenly
1) B - Unlisted
2) A - Listed <- Script working here
The script Lists what it THINKS is the correct item , leaving Item B unlisted.
I've looked into this and there is no way to fix this with the EQ2 system working as it stands.
If the items are different names and the order changes I already check for this and the script re-scans the broker list to get it's data right and stops. (I'm working on a more elegant solution to keep the script scanning)
But with 2 items of the same name I have nothing to compare or check against , there is no unique ID on items in your broker list I can check for.
The 2 ways to currently stop this happening are
1. Always drop items into the broker system so they group up into one slot if they are in the same container.
2. Change the script so it goes through the consignment system and sets everything to Listed after a scan has been done.
Last edited:
nilsar said:
The first 3 sound like you're having problems with the broker system or not actually targetting a broker when running it , I've tried and tried and can't re-produce them , are you runing the latest version from the SVN ?
4th one...thats on my to-do list.
Thats...unusual...Busygal said:
It uses the same textures/boxes/textboxes etc that EQ2 uses , do you run any other scripts that use them? , /Craft uses the same textures etc that I do...to see if thats where the problem lies..
Only other thing I could think of would be to delete the mypricesUI.xml file from the Scripts/UI/ folder and re-download it from the SVN.
Otherwise all I can think of is you have corrupt EQ2 UI texture files somewhere.
I'm just about to release an update to the GUI (smaller footprint) along with some improvements to the search code , perhaps this will help.Busygal said:
I have read in other forums on here of other people having similar GUI problems with other scripts recently , there might be a common problem.
bjcasey
ISX Specialist
Nice program. I specifically like the buy routine. One problem I noticed, if the person you are buying from has more than 200 of a stacked item up for sale the bot will try to buy more than 200 of that item. This of course is a problem for the eq2 broker window as the max amount you can purchase at one time is 200. The same problem occurs if you don't have whole amounts of an item in your inventory.
bjcasey
ISX Specialist
Few other small glitches today. I'm trying to buy any Tynnonium Cluster up to 15 total for 3.6p. Occasionally the bot will do this and report this in the console.
Verifying ISXEQ2 is loaded and ready
Running MyPrices version 0.09a - released : 20 Nov 2007
Buying (1) Tynnonium Cluster at 0.020000
Buying (14) Tynnonium Cluster at 0.020000
But when I check my bags the clusters have not been purchased. Is this a case of someone listing an item quickly and then removing it before the bot can purchase? Or someone else (possibly another bot) buying it before my bot does? The real problem occurs that when it thinks it has purchased something the max purchase number is decreased. So in the above example I only want 15 clusters and it thinks it bought 15 clusters so it stopped searching for that item.
Verifying ISXEQ2 is loaded and ready
Running MyPrices version 0.09a - released : 20 Nov 2007
Buying (1) Tynnonium Cluster at 0.020000
Buying (14) Tynnonium Cluster at 0.020000
But when I check my bags the clusters have not been purchased. Is this a case of someone listing an item quickly and then removing it before the bot can purchase? Or someone else (possibly another bot) buying it before my bot does? The real problem occurs that when it thinks it has purchased something the max purchase number is decreased. So in the above example I only want 15 clusters and it thinks it bought 15 clusters so it stopped searching for that item.
Thats a possibility....though it looks like someones putting them up for sale , realising they didn't set a price (0.02 is 2 copper) and quickly taking them down.bjcasey said:
Unfortunately your broker list doesn't update straight away when that happens...
Or , it could be someone did this and someone else (could be a bot) beat you to it..
I will have to put in a routine to check for this.
Either
1) scan your bags and keep totals of items you want to buy , then re-scan your bags after buying something to make sure the total was increased , (slow but will never be wrong)
2) check your cash left and do a quick calculation on how many were bought based on how much was spent (faster but might be less accurate).
3) Or find an event that happens when something is bought and work from that.
(Not sure how this would work)
I'll look into it.
Last edited:
0.9c - Released
Ok , I went with option 2 , using how much coin you spent to calculate how many items you bought.
Scanning all the bags every time you tried to buy an item took too long.
Using an event to look for returned text when you bought items worked well, until text lag meant it didn't register buying several items until way after they were bought.
I can't take a chance on people buying more than they want, especially if the items are expensive.
I reduced the amount that will be bought each time to 100 max , so stacks of harvests will be bought in 2 x 100 blocks (only harvests can be bought in 200 blocks , the rest still have a 100 limit so it was causing errors).
As soon as I can figure out an easy/fast way to check if an item being bought is a harvest or not I can change that.
I also stopped the script from moving on from a vendor until it had finished buying all they had if you hadn't reached your limit
(Before it would buy 200 and then move on , even though there were still some left on that particular broker entry)
I've updated the SVN with version 0.9c
Ok , I went with option 2 , using how much coin you spent to calculate how many items you bought.
Scanning all the bags every time you tried to buy an item took too long.
Using an event to look for returned text when you bought items worked well, until text lag meant it didn't register buying several items until way after they were bought.
I can't take a chance on people buying more than they want, especially if the items are expensive.
I reduced the amount that will be bought each time to 100 max , so stacks of harvests will be bought in 2 x 100 blocks (only harvests can be bought in 200 blocks , the rest still have a 100 limit so it was causing errors).
As soon as I can figure out an easy/fast way to check if an item being bought is a harvest or not I can change that.
I also stopped the script from moving on from a vendor until it had finished buying all they had if you hadn't reached your limit
(Before it would buy 200 and then move on , even though there were still some left on that particular broker entry)
I've updated the SVN with version 0.9c
Last edited:
Originally Posted by nilsar
getting an error
1) error unable to mark NULL as listed for sell
this is when the first 3 options are checked works ok with just first 2
2) also when i check the first 2 boxes it never changes from non list to listed on completing.
3) when comparing a spell i have for sell Pariah's Strike (Adept I) at 99g
it say there is no match marks it as red and moves on when there are 4 others up and it doesnt match the price.
4) also compacting the display window would be great so you could get broker, isxqe2 console and yours onscreen at one time for viewing would be great.
nilsar
I was having #1 happening too... I found that if I had resorted my selling boxes so they weren't alphabetical then I would get the "null" error ... as soon as I switched it back to sorting alphabetical then it would work fine... home that helps
getting an error
1) error unable to mark NULL as listed for sell
this is when the first 3 options are checked works ok with just first 2
2) also when i check the first 2 boxes it never changes from non list to listed on completing.
3) when comparing a spell i have for sell Pariah's Strike (Adept I) at 99g
it say there is no match marks it as red and moves on when there are 4 others up and it doesnt match the price.
4) also compacting the display window would be great so you could get broker, isxqe2 console and yours onscreen at one time for viewing would be great.
nilsar
I was having #1 happening too... I found that if I had resorted my selling boxes so they weren't alphabetical then I would get the "null" error ... as soon as I switched it back to sorting alphabetical then it would work fine... home that helps
Ok , I've seen what happens , it's the same thing as a previous problem...Busygal said:
If you sort the containers by anything but the default order (Name) then the server re-sorts the contents of your broker list on the fly as you set an item to Listed for sale..
So stuff jumps up and down your broker list..this causes problems when trying to track which item is supposed to be being looked at , the broker list is suddenly NULL (a blank entry) where the item USED to be when this happens , hence the script looking for an item called NULL.
I may be able to code around this (somehow) , but in the meantime...if you use the script , make sure you have the items in the default order which is alphabetically by Name
0.9f - minor release and bugfix
Ok , the script now really doesn't care how the items are sorted on your container list...I mean it this time...
sorting your items by Listed caused some wierd problems , now fixed.
Small update to other parts of the script also to simplify it somewhat.
Script will collect any money on your broker from sales automatically from each selling container as it scans them , you can now afford those extra items you wanted to be automatically bought
Ok , the script now really doesn't care how the items are sorted on your container list...I mean it this time...
sorting your items by Listed caused some wierd problems , now fixed.
Small update to other parts of the script also to simplify it somewhat.
Script will collect any money on your broker from sales automatically from each selling container as it scans them , you can now afford those extra items you wanted to be automatically bought
Pygar
EQ2Bot Specialist
Feature Request:
Parse the sell list for crafted items, and have the ability to update a saved recipe list for craft.
Basically your script could update a 'myprices.xml' that is a saved craft list. Basically ease the process of replenishing your store of crafted items.
I stock over 120 unique crafted items on my store, I go cross-eyed reading the sell lists to figure out what to make to replenish.
Parse the sell list for crafted items, and have the ability to update a saved recipe list for craft.
Basically your script could update a 'myprices.xml' that is a saved craft list. Basically ease the process of replenishing your store of crafted items.
I stock over 120 unique crafted items on my store, I go cross-eyed reading the sell lists to figure out what to make to replenish.
Pygar I use a little utility called eq2storelogparser
http://eq2.wikia.com/wiki/Eq2storelogparser
Basically you just open the game log with it, set the date range and look to see the quantity of items sold and not count how many sold to each person. It also has graphs so you can tell which of your items sell better than others so you know what to stock more of on the broker.
While it doesn't automatically make a craft list it makes it much easier to replenish your crafted items.
http://eq2.wikia.com/wiki/Eq2storelogparser
Basically you just open the game log with it, set the date range and look to see the quantity of items sold and not count how many sold to each person. It also has graphs so you can tell which of your items sell better than others so you know what to stock more of on the broker.
While it doesn't automatically make a craft list it makes it much easier to replenish your crafted items.
speedycerv
Active Member
I'm having trouble with the latest version. I have everything set how I used to, with both auto-matches on, and scan sales checked. I start it up to update my selling prices and it color codes every item black, and doesn't change any of them now. I didn't change anything except update the script to the latest version.
Ok , I have an idea about the best way to do this...Pygar said:
tell me if I'm on the right track..
Clickbox to mark an item as a craft item (when you edit the minimum price on the first tab)
New tab named 'craft'
When you go into that tab all the items with the flag 'craft item' are listed..
You can set/update a number against each one.
As the script scans your broker list it totals how many of each you have left (across all containers).
After it's done a scan for items being sold and added up all the totals , it compares what it has counted against all your craft flagged items
that it knows about.
It then creates/updates a craft list with how many you need to make to replenish your stocks if any of them are below the set number.
Last edited:
Version 0.10a on SVN
Version 0.10a
-------------
Started work on the script to produce a craft recipe file ready for loading , currently only echos whats needed onto the
lavish console (work in progress , try it and let me know what you think)
Fixed the text on the Sell Tab to be in the right places...
Once I've looked at the structure of crafts recipe save files it shouldn't take long to re-create one automatically.
(Famous last words)
Version 0.10a
-------------
Started work on the script to produce a craft recipe file ready for loading , currently only echos whats needed onto the
lavish console (work in progress , try it and let me know what you think)
Fixed the text on the Sell Tab to be in the right places...
Once I've looked at the structure of crafts recipe save files it shouldn't take long to re-create one automatically.
(Famous last words)
Last edited:
bjcasey
ISX Specialist
After you get everything with the export to /craft working I have a feature request.
The ability to search and buy items expanded to menus similar to the broker window. IE. level ranges, by type, ect.
Would be useful to transmuters to be able to buy for example all adepts in the 20-29 range for less than 4g.
The ability to search and buy items expanded to menus similar to the broker window. IE. level ranges, by type, ect.
Would be useful to transmuters to be able to buy for example all adepts in the 20-29 range for less than 4g.
Question
I've been looking at the script and thinking about how it works...
I've realised that if someone doesn't want to increase their prices if they have items lower priced than anyone else , there really is no reason to unlist the current broker item being looked at.
When I put a check in that stopped the item being unlisted if the 'increase price' option was not checked, the speed of the scan doubled (it also wasn't so obvious as the only thing someone would see is the price being changed).
However it did mean items were never shown as 'yellow' (lowest price) on the GUI list....
What do people think about me adding the code to stop un-listng if not needed and losing yellow item markers showing you are selling at the lowest price?
I've been looking at the script and thinking about how it works...
I've realised that if someone doesn't want to increase their prices if they have items lower priced than anyone else , there really is no reason to unlist the current broker item being looked at.
When I put a check in that stopped the item being unlisted if the 'increase price' option was not checked, the speed of the scan doubled (it also wasn't so obvious as the only thing someone would see is the price being changed).
However it did mean items were never shown as 'yellow' (lowest price) on the GUI list....
What do people think about me adding the code to stop un-listng if not needed and losing yellow item markers showing you are selling at the lowest price?
Version 0.10b in SVN
Pressing the craft button will now create a favourite in the craft script datafile containing details and numbers of
the stock your broker list is short, you can choose to load this list and craft will re-create the stock you are
missing from your broker.
**Warning** : this is still work in progress , the list will be created correctly but the script doesn't actually
check you have run the craft script , the file/directory may not be there if you don't use the craft script or
don't download all of the SVN - checks for missing files will be added soon.
Pressing the craft button will now create a favourite in the craft script datafile containing details and numbers of
the stock your broker list is short, you can choose to load this list and craft will re-create the stock you are
missing from your broker.
**Warning** : this is still work in progress , the list will be created correctly but the script doesn't actually
check you have run the craft script , the file/directory may not be there if you don't use the craft script or
don't download all of the SVN - checks for missing files will be added soon.
Last edited:
mycroft I haven't looked at it yet, however did you incorporate anything into the craft code to count multiple items in a craft, say a potion if you sell 4 and the myprices says I sold 4 and need to make 4 you would essentially be making 40 of them if you did 4 crafts.
Would need a divide by 10 for potions and poisons, and arrows divide by 100 etc.
Would need a divide by 10 for potions and poisons, and arrows divide by 100 etc.
I'm going to have to re-design myprices somewhat...
The current setup works if you only use it to sell from one character , selling one type of craft item (woodworker/jeweler items)
I realised today that as soon as you use the script on more than one character you will get craft items from each character appearing in the list..
So I'm going to take time to make a single craft list per character instead of just one list , while I'm doing this I willl move the data files into their own folder and tidy up the file work..
So version 11 may need you to re-start your item minimum prices etc from scratch.
The current setup works if you only use it to sell from one character , selling one type of craft item (woodworker/jeweler items)
I realised today that as soon as you use the script on more than one character you will get craft items from each character appearing in the list..
So I'm going to take time to make a single craft list per character instead of just one list , while I'm doing this I willl move the data files into their own folder and tidy up the file work..
So version 11 may need you to re-start your item minimum prices etc from scratch.
Last edited:
I just updated the SVN with a small bugfix , the craft button function wasn't clearing old entries from the list each time it was run...
So you got previous items being included in the craft favourite even if your 'stock levels' were fine when the button was pressed.
The script now clears all old values from the list before writing a new one.
So you got previous items being included in the craft favourite even if your 'stock levels' were fine when the button was pressed.
The script now clears all old values from the list before writing a new one.
Version 0.11a
1. I Changed the way the script stores datafiles , each character that uses the script now has their own datafile.
(If you run the script on more than one character then each item marked as a craftable item will now be specific to that character.)
If you want to use your existing (pre-version 11) datafile for one or more of your characters do the following
Copy/Move the file MyPrices.xml file into the XML folder inside your script folder
Rename the MyPrices.xml file charactername_MyPrices.xml
So if the character is called Mycroft
\scripts\myprices.xml becomes \scripts\XML\Mycroft_MyPrices.xml
2. I Updated the script to remove a lot of duplicate indexing - it's much more efficent and a fair bit smaller now.
3. The script will no longer unlist broker items unless the 'Auto-match Higher Prices' option is checked or Re-List items if they are already listed for sale
, this speeds up scans by a large amount.
1. I Changed the way the script stores datafiles , each character that uses the script now has their own datafile.
(If you run the script on more than one character then each item marked as a craftable item will now be specific to that character.)
If you want to use your existing (pre-version 11) datafile for one or more of your characters do the following
Copy/Move the file MyPrices.xml file into the XML folder inside your script folder
Rename the MyPrices.xml file charactername_MyPrices.xml
So if the character is called Mycroft
\scripts\myprices.xml becomes \scripts\XML\Mycroft_MyPrices.xml
2. I Updated the script to remove a lot of duplicate indexing - it's much more efficent and a fair bit smaller now.
3. The script will no longer unlist broker items unless the 'Auto-match Higher Prices' option is checked or Re-List items if they are already listed for sale
, this speeds up scans by a large amount.
Issue I have noticed since updating to .11
If you set a Min Price and run the script. It wont update a new min price in the file.
Also could you use a Folder structure like EQ2MyPrices so we can keep all the script files in one place like craft does.
Additional info:
I found if you change the price by silver it works. But it isn't changing copper at all.
Trying to use the craft favorite feature. It looks as though Myprices only makes a CHAR_myprices file and dosen't append the data file used by craft. Are you working with Blazer to add a possable switch to craft?
IE /craft myprices so it will load the myprices xml? Or are we just going to have to copy it manually? Having it append the current file would be great.
If you set a Min Price and run the script. It wont update a new min price in the file.
Also could you use a Folder structure like EQ2MyPrices so we can keep all the script files in one place like craft does.
Additional info:
I found if you change the price by silver it works. But it isn't changing copper at all.
Trying to use the craft favorite feature. It looks as though Myprices only makes a CHAR_myprices file and dosen't append the data file used by craft. Are you working with Blazer to add a possable switch to craft?
IE /craft myprices so it will load the myprices xml? Or are we just going to have to copy it manually? Having it append the current file would be great.
Last edited: