Someone was talking about looking at EQ2Bot as an example of a good bot or something in IRC so I figured I'd take a peek at the code.
I see a lot of Math.Calc where it's already going through the calculator. For example... "if" (and while, for, etc), float:Set (and int:Set, and so on), and Math.Calc are all documented and all identically say they use formula. I say this because everywhere I see a subtraction in an "if", it's enclosed in Math.Calc. "if ${Math.Calc[${Time.Timestamp}-${chktimer}]}>3". That's doing absolutely notihng different than "if ${Time.Timestamp}-${chktimer}>3", except looking impossible to read and going through extra steps. Logical math operators like || && > == < are no different from other math operators like - + * / ~ | & !... they're all processed by the calculator. The same thing applies as I said to float:Set, int:Set, or other Set methods of numeric types (these are explicitly documented as such).
X:Set[${Math.Calc[-4*${Math.Sin[-${Target.Heading}]}+${Target.X}]}]
can be
X:Set[-4*${Math.Sin[-${Target.Heading}]}+${Target.X}]
...and so on.
This is of course different for things that DONT use formulae. For example..
while ${EQ2Bot.ConvertAngle[${Math.Calc[${Target.Heading}-${Me.Heading}]}]}>80
This Math.Calc is necessary unless EQ2Bot.ConvertAngle specifically supports being given 120-80, because it's NOT being run through the calculator.
Other than that, I don't see anything that's your fault, at least in EQ2Bot.iss (not looking through the other stuff). A lot of things could be done better in ISXEQ2 to speed things up. Switching to LavishNav and LavishSettings would of course be optimal, but that doesn't bother me like the Math.Calc thing.
P.S. Amadeus: The forum layout sucks. I didn't realize there were sub-forums until I couldn't find EQ2Bot and someone swore it was on isxgames, then I had to click 14 times to get through all the sub-forums to find the bot. Can't sub-forums be expanded in the forum list?
I see a lot of Math.Calc where it's already going through the calculator. For example... "if" (and while, for, etc), float:Set (and int:Set, and so on), and Math.Calc are all documented and all identically say they use formula. I say this because everywhere I see a subtraction in an "if", it's enclosed in Math.Calc. "if ${Math.Calc[${Time.Timestamp}-${chktimer}]}>3". That's doing absolutely notihng different than "if ${Time.Timestamp}-${chktimer}>3", except looking impossible to read and going through extra steps. Logical math operators like || && > == < are no different from other math operators like - + * / ~ | & !... they're all processed by the calculator. The same thing applies as I said to float:Set, int:Set, or other Set methods of numeric types (these are explicitly documented as such).
X:Set[${Math.Calc[-4*${Math.Sin[-${Target.Heading}]}+${Target.X}]}]
can be
X:Set[-4*${Math.Sin[-${Target.Heading}]}+${Target.X}]
...and so on.
This is of course different for things that DONT use formulae. For example..
while ${EQ2Bot.ConvertAngle[${Math.Calc[${Target.Heading}-${Me.Heading}]}]}>80
This Math.Calc is necessary unless EQ2Bot.ConvertAngle specifically supports being given 120-80, because it's NOT being run through the calculator.
Other than that, I don't see anything that's your fault, at least in EQ2Bot.iss (not looking through the other stuff). A lot of things could be done better in ISXEQ2 to speed things up. Switching to LavishNav and LavishSettings would of course be optimal, but that doesn't bother me like the Math.Calc thing.
P.S. Amadeus: The forum layout sucks. I didn't realize there were sub-forums until I couldn't find EQ2Bot and someone swore it was on isxgames, then I had to click 14 times to get through all the sub-forums to find the bot. Can't sub-forums be expanded in the forum list?