EveBot:Ratter - Fixed Drone Deployment

Status
Not open for further replies.
R

rockstar

Member
Currently Tested With: SVN Stable Revision 1681

1st off a huge thanks to noob and cybertech on IRC for working through this over the last 2 days with me.

What is this patch?

It is a proposed change to address the way EveBot:Ratter deploys drones. I wanted something that waited for all targets that should lock and actually start shooting the bot before deploying drones.

What makes this patch different from the proposed changes already available?

  • We've added code to obj_Targets.iss for a function to solely detect hauler type special spawns. This is needed because haulers are counted in the belt but do not normally shoot the bot and would have made our generic deployment code in obj_Combat.iss in-accurate in those cases.
  • We've added code to obj_Combat.iss to detect not when an NPC has simply locked you (yellow boxed) but rather when they are actually shooting you (red boxed). Thanks to CCP logic if they simply yellow box you and you deploy drones the NPC may switch to a drone, if you are red boxed they will never stop targeting you. This was the fault with the original changes I've seen on the forums (using GetTargetedBy, GetTargets).
  • Also you will see a lot of code that seems to replicate the function of GetAttackers. It is accurate to say that. According to CyberTech the GetAttackers and GetAttackers[:index] functions are broken at the Eve level therefore we needed to re-invent the wheel a bit.

I've tested this patch a great deal personally and feel confident it should work as described. I have not personally had a chance to run it under the code that is being deployed today. I also have not encountered a hauler spawn with it yet either. If people can provide input there I would greatly appreciate it.

In order to get the files on the board it had to be zipped. A .patch file is not accepted.

Enjoy People!

~ rockstar ~

:: Update: 20 Dec 2010 ::
- I have ran this code under the current TQ release (Incursion 1.0.2) and it works as advertised with the exception of not having a hauler spawn to test this on yet.

:: Update: 28 Dec 2010 ::
- Tested with upstream SVN releases
- Changed obj_Drones.iss to not spam the logs as much (commented out a DEBUG line)
- Changed obj_Drones.iss default values to bring drones back earlier than past cases if agro is mis-calculated somehow to prevent drone armor damage
 

Attachments

Last edited:
B

Bal

Member
Question, with patching this the correct way is to right click the file go apply patch, then click the save button then close the patch window? Was having problems after trying this I believe it was my noobness.
 
B

Bal

Member
I have been testing this for the last few days, a huge improvement on drone performance. Thank!!!.

Note: I noticed that after undocking sometimes the bot couldn't activate mods but I believe this is a bug with evebot itself not to do with this patch.
 
R

rockstar

Member
Bal said:
I have been testing this for the last few days, a huge improvement on drone performance. Thank!!!.

Note: I noticed that after undocking sometimes the bot couldn't activate mods but I believe this is a bug with evebot itself not to do with this patch.
Click to expand...
I've seen this as well. Happens when jumping for me also. Glad you like the new drones fix. Makes the Dominix useful for Ratter and the Dominix is my ultimate favorite carebear ship! Gotta have my space potato in the morning.

~ rockstar ~
 
D

Damos06

Member
Maybe I'm an idiot but how do I patch this. I read through that site and not sure what to do with it.... can someone give a quick walkthrouh. Please.
 
B

Bal

Member
Right click the patch file you download click apply patch click the 2 objs in the window that is opened then click save.
 
N

neothereal

Member
I tried this. Once I unzipped it, then went to patch file, right clicked, and no option to apply patch.

I also downloaded that patching program, but that confused me even more.


What else am I missing?
 
Last edited:
G

guardian

Member
noticed a small bug it appears

2 frigate npc's in the belt

the status list showed that the script saw them as "split aggression" but they were both attacking my ship

no other NPC's in the belt.
 
N

neothereal

Member
rockstar said:
Currently Tested With: SVN Stable Revision 1681

1st off a huge thanks to noob and cybertech on IRC for working through this over the last 2 days with me.

What is this patch?

It is a proposed change to address the way EveBot:Ratter deploys drones. I wanted something that waited for all targets that should lock and actually start shooting the bot before deploying drones.

What makes this patch different from the proposed changes already available?

  • We've added code to obj_Targets.iss for a function to solely detect hauler type special spawns. This is needed because haulers are counted in the belt but do not normally shoot the bot and would have made our generic deployment code in obj_Combat.iss in-accurate in those cases.
  • We've added code to obj_Combat.iss to detect not when an NPC has simply locked you (yellow boxed) but rather when they are actually shooting you (red boxed). Thanks to CCP logic if they simply yellow box you and you deploy drones the NPC may switch to a drone, if you are red boxed they will never stop targeting you. This was the fault with the original changes I've seen on the forums (using GetTargetedBy, GetTargets).
  • Also you will see a lot of code that seems to replicate the function of GetAttackers. It is accurate to say that. According to CyberTech the GetAttackers and GetAttackers[:index] functions are broken at the Eve level therefore we needed to re-invent the wheel a bit.

I've tested this patch a great deal personally and feel confident it should work as described. I have not personally had a chance to run it under the code that is being deployed today. I also have not encountered a hauler spawn with it yet either. If people can provide input there I would greatly appreciate it.

In order to get the files on the board it had to be zipped. A .patch file is not accepted.

Enjoy People!

~ rockstar ~

:: Update: 20 Dec 2010 ::
- I have ran this code under the current TQ release (Incursion 1.0.2) and it works as advertised with the exception of not having a hauler spawn to test this on yet.

:: Update: 28 Dec 2010 ::
- Tested with upstream SVN releases
- Changed obj_Drones.iss to not spam the logs as much (commented out a DEBUG line)
- Changed obj_Drones.iss default values to bring drones back earlier than past cases if agro is mis-calculated somehow to prevent drone armor damage
Click to expand...
It doesn't seem to work with HAULER spawns. What tweak can I do to test it?

Anyone else can confirm this?
 
G

guardian

Member
can an update to this code be made so it will work in build 1827?

currently when you try to patch over, there is at least 2 lines of code that have conflicts and i am not sure how to modify the patch so it works correctly.
 
tempest26

tempest26

Well-Known Member
guardian said:
can an update to this code be made so it will work in build 1827?

currently when you try to patch over, there is at least 2 lines of code that have conflicts and i am not sure how to modify the patch so it works correctly.
Click to expand...
This what I am using, I cannot guarentee I didn't break something else, but it seems to work
 

Attachments

B

Bal

Member
This really needs to be added into EVEbot itself, without it using drones is pointless unless you like getting new ones everyday.
 
G

guardian

Member
Valerian said:
Double checked and merged original patch with current stable. Patch below made against SVN revision 1876.

Whoever said you can't attach a .patch file must be insane.
Click to expand...
thanks for that val, im sure alot of people are thankful ( and they should say so on the forums!!! )
 
D

Dark_Ghost

Well-Known Member
Valerian said:
Double checked and merged original patch with current stable. Patch below made against SVN revision 1876.

Whoever said you can't attach a .patch file must be insane.
Click to expand...

that worked perfectly, thank you!

and thanks to thoes involved the patch works very well!
 
T

Taro

Member
Any idea if this works with the newly released version of isxeve?

Since i got the new version, my drones are dieing a lot.
 
CyberTech

CyberTech

Second-in-Command
Staff member
This is an extremely old patch which should not be used any longer. Closing this thread.
 
Status
Not open for further replies.
Top Bottom