MyPrices

Status
Not open for further replies.

mycroft

Script Author: MyPrices
Update

Updated the search routine to include Checking for situations where your price was lower than the next lowest price.

Some bugs squashed.

An assumption about the location you are selling from was hopefully sorted so it should work from any good/evil character now.


The setting of minimum price to set the item to didn't make this cut down version , I'm still working on saving/setting the values (I'm learning while writing it so it's slow work).

How to use:

1. Put this in your scripts folder
2. Target a broker and open the broker window..
3. type run myprices2 in the lavish window text line.

If you examine the script there are 2 commented lines that can be uncommented to automatically set the price of your item to match higher/lower prices.

Personally I uncomment the one that automatically increases the items price if my prices are too low , I'm waiting till I've finished writing the minimum price setting part of the script before letting it set a lower price for me.

Discussion Thread here

http://www.isxgames.com/forums/showthread.php?p=11336#post11336
 

Attachments

mycroft

Script Author: MyPrices
myprices 4

Updated the script to have a minimum price per item which it will not set the price below.


***** Do not use this version unless you feel confident in editing an XML setting file by hand, Use myprices2 instead *****

Please read the enclosed TXT file carefully if you do decide to try this script.

Any comments/questions gratefully received in the following thread as usual.

http://www.isxgames.com/forums/showthread.php?p=11336#post11336
 

Attachments

mycroft

Script Author: MyPrices
Version 2 Update

Fixed a problem where the first item found on the brokers list might be the wrong item and the script was using that as the initial 'lowest' price.
 

Attachments

mycroft

Script Author: MyPrices
Version 4 Update

Fixed a problem where the script was taking the price of the first item listed as the lowest price even if the name of the item was only a partial match to the item in broker sales box.
 

Attachments

mycroft

Script Author: MyPrices
Version 0.05

Continuing to develop version (4) , Version 0.0(5)

***** Do not use this version unless you feel confident in editing an XML setting file by hand, Use myprices2 instead *****
***** Myprices2 does not include some of the features or the GUI elements *****


I decided to start adding the GUI as working the various data files by hand was becoming cumbersome.

Added the initial GUI tabs , tickboxes to set/change prices automatically and Buttons to start/stop a continual scan and Stop/Quit the script.

The next update should include a list in the GUI of all items you are selling , clicking on an entry willl let you enter the minimum price you will sell that item for without having to edit XML files by hand.

Then I can patch in the Buy items code and it's GUI parts.
 

Attachments

mycroft

Script Author: MyPrices
Version 0.06

***** Do not use this version unless you feel confident in editing an XML setting file by hand, Use myprices2 instead *****
***** Myprices2 does not include some of the features or the GUI elements *****



Changes :

Added an option to Auto-Price unlisted items and set them as Listed.
 

Attachments

Last edited:

mycroft

Script Author: MyPrices
Myprices 0.07

Version : 0.07
--------------

Added various extra options to the GUI and made running/using the script totally GUI driven

No more editing setting files by hand!
 

Attachments

mycroft

Script Author: MyPrices
Version 0.08

Version : 0.08
--------------

Updated the script to remove all XMLSetting commands and use Lavishsettings instead.
(It's an old system thats not being supported any more according to Lax)

Condensed some of the script to remove duplicated code and replace them with single shared functions.

Added colored indicators to the Broker list in the GUI to mark how your items are priced compared with other broker prices.


Next planned update (0.09) : Add the Buy item code and options
 

Attachments

mycroft

Script Author: MyPrices
0.08b

Available and Updated via the SVN

Fixed a small bug where unlisted items were getting their Minimum Price reset even though there was already one set.

Preview of the Buy system UI tab included , unworking yet.
 

mycroft

Script Author: MyPrices
Version 0.08c

** Available and Updated via the SVN **

Version : 0.08c
---------------
Vastly simplified and improved the code to handle the item list color changes and GUI information updating.
(No more scrolling list - the color just changes without the text being moved - Thanks for the pointer Lax)

Updated a huge portion of the code to simplify the various methods/functions used.

Updated the GUI to remove all XMLSetting references it now calls various routines that use Lavishsettings instead.

Bugfix : Adding a new item sometimes left the current price boxes for that item permanently empty.
 

mycroft

Script Author: MyPrices
Version 0.8d

Version : 0.08d
---------------
Additional option added :

Each item for sale now can be flagged to check for a minimum price or not , if not flagged then the lowest price on the broker
will always be matched regardless of it's cost.

**** ALL ITEMS when you run this version for the FIRST time will NOT be flagged to check your minimum price ****

**** Go through the list and tick the box against all items you want a minimum price checked and press the save button on each *****

Added additional lag checking code for when the script is setting and un-setting items for sale to try and stop items being left unlisted.

Discussion thread here : http://www.isxgames.com/forums/showthread.php?p=11994#post11994
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.8e

Version 0.8e now released via SVN

1) Scanning now faster if more than one page of items is on the broker.
2) GUI has been reduced in size by about 50% in width and 10% in height.
3) New option Ignore Copper , if the matching price is over 1 gold then any Copper is ignored when setting the new price.

(Doesn't work if you set a minimum price over 1 gold that includes coppers)

You can make a Buy Item list now , The function code to actually buy the items in the list has been snipped out till I'm 100% sure it's working fully.

Feel free to test adding and deleting items in the list though.

Discussion Thread here : http://www.isxgames.com/forums/showthread.php?t=1808&page=4
 

mycroft

Script Author: MyPrices
Version 0.8e Bugfix

Updated the SVN

Emergency Update Bugfix : An error crept in when a new item was added , the previous items price was used.

Please update your current version asap.
 

mycroft

Script Author: MyPrices
Version 0.9a

Version 0.9a - released into the SVN
----------------

Buy Routine added:

The script can now buy items at or below a defined price upto a set number of items.

1) It does not stop until either you a) run out of money with more to buy or b) it has bought all the items you asked it to.
2) It currently doesn't check for empty bag slots , extra items bought SHOULD go into your overflow.

Turn on Auto-Loop to get it scanning for items to buy continually.

It will buy the cheapest items listed first..

If you have it scanning your sale items as well , it will alternate checking your sale items first the scanning for the items to buy.

The buy script was fairly well tested with it constantly scanning for the last 2 days.

(It cost me the tune of 5pp - when a bug reared it's ugly head earlier on in it's coding)
which is why it's been soak tested for the last 2 days before being released.

But I still recommend you try it with something really cheap (2c) before you decide to trust it with a more expensive item.


New button : You can now toggle the scan sales option on and off if you wish to just scan for items to buy.

Discussion Thread is here : http://www.isxgames.com/forums/showthread.php?p=12133#post12133
 
Last edited:

mycroft

Script Author: MyPrices
I just added a quick workaround because ISXEQ2 wasn't finding items with a level 71 or above level by default , it should find anything again now.
 

mycroft

Script Author: MyPrices
0.9c - Released in SVN

Added checks to make sure you had actually bought items before reducing the number you had set.

Max number of items bought at once is reduced to 100 at a time for the moment

Bugfix : Script now keeps buying items from the current vendor instead of moving onto the next in the list if they still have more available than the 100 max.
 

mycroft

Script Author: MyPrices
0.9e Released via SVN

Version 0.9c-0.9e
----------------------

Major code revision:

The script no longer cares where the item being looked at is in your broker list , it will work fine now however you
sort your list , by name , price , listed , it should find and list/change/unlist them without any problems.

Added : All changes are now logged in the Log Tab instead of the Lavish Console Window , press 'clear' to clear the entries.
 

mycroft

Script Author: MyPrices
Version 0.9f

sorting your sales items by Listed caused some wierd problems , now fixed.

Simplified several parts of the script.

Script now collects any money on your broker from sales as it scans each container
 

mycroft

Script Author: MyPrices
Version 0.9g

Added an option to Pause the script between scans if Auto-Loop is toggled on

Fixed a problem with setting the minimum price of an item.
 

mycroft

Script Author: MyPrices
Version 0.10a

Version 0.10a
-------------

Started work on the script to produce a craft recipe file ready for loading , currently only echos whats needed onto the
lavish console (work in progress , try it and let me know what you think)

Fixed the text on the Sell Tab to be in the right places...
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.10b

The Craft Button now integrates with the craft script , creating a favourite list entry called myprices that can be loaded when you run the craft script.
 

mycroft

Script Author: MyPrices
Version 0.11a

1. Each Character now has it's own datafile

2. I Updated the script to remove a lot of duplicate indexing.

3. The script will no longer unlist broker items unless the 'Auto-match Higher Prices' option is checked or Re-List items if they are already listed for sale.
 

mycroft

Script Author: MyPrices
Still the same version number - SVN update , craft button wasn't updating the list if there were 0 items on your broker.

I'm still working on the 'fuzzy logic' buy search options
 

mycroft

Script Author: MyPrices
SVN Update

Fix : Script reverted to not clearing item totals when you unmarked them as crafted ones
 

mycroft

Script Author: MyPrices
Version 0,11f
-------------

Added new option 'Merchant Match' clicking this won't lower your prices below what you can get from selling to an NPC.

Added options to click on the buy list to do 'fuzzy' searches , you can set partial names 'master i)' Item start and end levels ,
max price , and tier. This will only work by clicking on each entry in the buy tab , problems with people putting items up for sale
such as high level fabled conjuror shards at 60g stopped me adding it to the usual automatic buy search routine.

This change means you will NEED to goto your buy list , on items where you will just search for a particular name , click on
each entry, click on the 'name only' tickbox and press 'save'

Due to how ISXEQ2 currently handles the MaxPrice paramater (it doesn't search for actual cost price but the sellers set price) means
your search will return items minus the cost of commission in the list.
 

mycroft

Script Author: MyPrices
Version 0.11f Rev 3

Version 0.11f Rev 3
-------------------

Added a button to let you unset an item in the craft tab , select the item in the list and press Unset , the item will be
unmarked as a craft item and the list will refresh.

Fixed a bug where items marked as craft items on one character were also being saved as craft items on another.

Several Minor bigfixes.
 

mycroft

Script Author: MyPrices
Version 0.11f Rev 3

Version 0.11f Rev 4
-------------------


Added tickboxes for each broker box , unchecked tickboxes will make that container be ignored by the script.
 

mycroft

Script Author: MyPrices
Version 0.11f Rev 5

Version 0.11f Rev 5
-------------------

Added Natural Scan option , makes it look less like a script is doing the broker scans , slows down the list scan a little.
 

mycroft

Script Author: MyPrices
Version 0.12

Version 0.12
------------

New button , Place Items

This will make the script scan your bags for items marked in your craft list , if any are found it will place them in the broker system for
you automatically , grouping items together if the same name.

1. It goes through your craft flagged items one by one.
2. The script searches for items of the same type , if found the items are placed in that box until they are all added or that box is full.
3. If there is no (more) space in a box with the same type of item or no matching items in your broker slots, then it places the items in
the box with the enough space to fit ALL those items in your inventory.
4. If no box has enough space to fit all of those items it distributes them between the boxes (filling boxes with the most space first).
5. it stops when you have no more space left anywhere.
 

mycroft

Script Author: MyPrices
Version 0.12b

Version 0.12b
-------------

With Ama's recent fix to the commission system when run with the market bulletin boards, the script will now auto-click your board then target your character when run so you no longer need to open the broker system at all before running the script , just ensure you are within range of a broker or your room board.
 

mycroft

Script Author: MyPrices
Versions 12.c - 12.e

Now has more logging (if toggled on)

Script will now Pause if your mouse moves off the Broker window for any reason as this causes problems with changing values on the broker , the script will resume when the Broker window has the mouse on it again.
 

mycroft

Script Author: MyPrices
Version 0.12f

Added a small workaround to stop new items reading as having their prices set to 0 if they are new to your broker list..

As the broker list is scanned initially...any item with a baseprice reading as 0 has it's price set to the merchant equivalent and it is then immediately unlisted again.

This means for a fraction of a second the item is for sale at merchant prices.

But it also means that item when scanned a second time (for real) it will then be able to have it's price set properly.
 

mycroft

Script Author: MyPrices
Hopefully sorted the problem with missing / zero prices (thanks to Ama for his patience).

Also fixed a further problem with the creation of the craft list which making some of the changes to fix the zero price error made.

As a bonus the script now actually scans faster because of the changes.
 

mycroft

Script Author: MyPrices
version 0.12g

Added an option to sell at the same price as the lowest price on the broker (ignoring the sellers broker fee)

If you sell on the Freeport broker and someone in Qeynos is selling an item for 25g without commission then your same item will be set to 25g also.

It will appear on the Freeport broker as cheaper than the one for sale in Qeynos, but still show as more expensive to people scanning the Qeynos broker due to higher broker charges.
 

mycroft

Script Author: MyPrices
version 0.12i

Updated script so that if you add an item that nobody else currently has on the broker (nothing to compare your item to) and you have a
maximum price set for items of that name, then the script will set your new item to that price.
 

mycroft

Script Author: MyPrices
0.12i update

Quick Addon , if you pass the parameter SCAN to the script.

e.g. : run myprices SCAN


it will open the script , run the routine to scan your broker and then automatically exit.


Script options have to be set up initially before running the auto-scan.
 

mycroft

Script Author: MyPrices
version 0.12j

Re-added and updated the additional filters under the buy tab so they work on the automated buying option instead of just the item clicking

Use this with caution , I'd suggest not just filtering by tier etc , but also include partial names (adept i for example) in the name box.

Added a box to the Craft tab Box : Enter here the number of the box you want the script to place items in when you use the 'Place items' button on the Main Tab.

The script will fill up this box first then attempt to store the rest if it's full into the other boxes available. (Useful if you use the speciality broker storage boxes).
 

mycroft

Script Author: MyPrices
Version 0.13

Bugfixed the buy routine filters and actual item buying routines.

The buying routine will now look for an EXACT name match if you have the Name Only box ticked , otherwise it just checks for ANY items listed at all if you use the other filters.

Updated the readme.txt file also to bring it more upto-date.
 

mycroft

Script Author: MyPrices
Bugfixed : Small pause added to stop screens of items being skipped when buying

Bugfixed : Buy info not being re-saved correctly when running a buy scan.

Added : Pressing the Pause / Stop & quit button will now work when in middle of buying items.
 

mycroft

Script Author: MyPrices
Workaround :

Updated the buying routine , now if it is unable to buy the usual stack size (100/200) it will default to buying one item at a time until it has bought what it can / needs from the broker entry it is buying from.
 

mycroft

Script Author: MyPrices
Minor Update :

Added code so it recognises the Guild World Market Broker instead of trying to double-click the nearest non-agro NPC.
 

mycroft

Script Author: MyPrices
Small update

Added parameter PLACE to auto-place items then exit without having to press the UI button.

Script now accepts the following parameters

SCAN
PLACE
SCAN PLACE
PLACE SCAN

to run both routines individually or together from the command line.
 

mycroft

Script Author: MyPrices
Not sure what to do with this right now , LAX has changed the UI commands / methods recently , this has had a big knock-on for the Myprices UI , I don't understand the changes enough to fix the general UI XML files.

The scrollboxes and combo boxes don't want to work with the Guild hall brokers any more.


*Edit* it was all fixed , thanks whoever did it...should all work again.
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.13b

1. When you run the script it now loads the current settings and stores a backup of the file in a backup folder.

2. When it notices the character name has changed ( you leave the script running and do /camp newchar or even just camp with the script still running ) it saves the previous characters info and exits.

When you update from the SVN you should also see a folder called BACKUP being created.
 

mycroft

Script Author: MyPrices
Version 0.13c

Extra tickbox filter added to the buy tab , Attuneable only , filters the list so only attuneable items will be listed/bought.

Upcoming changes :

Add an option to Auto-transmute newly bought items after the buy routine has completed.
 
Last edited:

mycroft

Script Author: MyPrices
Added check for out of inventory space while buying items , script now stops buying if you run out of bag space.
 

mycroft

Script Author: MyPrices
Verision 0.12e released

1. Script should now handle items with commas in the name
2. Script will skip items that are attuned when using the 'place' button instead of trying and then moving on.
 

mycroft

Script Author: MyPrices
Versions f & g

Version 0.13g
-------------

Added auto-transmute option under buy tab.

Items bought using that filter will be automatically transmuted and the resulting powders/etc put in your bags.


Version 0.13f
-------------

1. If you change the value in the 'Current Price' boxes and hit save , it now changes your broker price for that item.

2. Changed the name of the myprices craft list from myprices to _myprices to put it at the top of the list when loading
it manually into the craft script.

So to load and run automatically use 'craft _myprices' or '/craft _myprices' instead of the older '/craft myprices'.
 

mycroft

Script Author: MyPrices
Version 0.13 h-j

Version 0.13j
-------------
Added the Admin TAB

After a while your data file will become clogged with old entries for items you have previously sold and the script slows down a lot.

Press the 'Compact' button and these will be removed. (mine went from 210k to 18k in size after 9 months use)

The script will not remove any items currently in your broker slots , Crafted Flagged items or any items with a Minimum or Maximum Sale Price set from your data file.


Version 0.13h-i
---------------
Small improvements in code , lore check when buying items and tidied the UI up a bit.
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.13k

Version 0.13k
-------------

The craft list creation routine also now scans your inventory for items , so if you get interupted, re-scan the broker to make the list again and any pre-made items in your inventory will be not be included from your craft totals.
 

mycroft

Script Author: MyPrices
Version 0.13l

Version 0.13l
-------------

Updated script to create the new craft recipe lists.
 

mycroft

Script Author: MyPrices
Version 0.13m

Updated script to to ignore any items in bags who have the 'Items are not for sale' flag set , ths affects the 'Place Items'
and 'Craft List' features.
 

mycroft

Script Author: MyPrices
Version 0.13n

Added Server name to the characters settings XML file to allow for people running 2 characters with the same name on diffrent servers.
 

mycroft

Script Author: MyPrices
Version 0.13q

New Tab : The Inventory TAB
===========================

From here , you can move items from your inventory individually to your broker boxes.

Press the rescan button to fill the list , press the item shown in the list and click on the numbered box button to place that item
on the broker in that sales box.

You can now also set items that you have newly crafted to be 'craft items' without having to move them to the broker first.

Click on the item in the list and fill in the information at the bottom boxes , tick the craft box , press save and that item will be marked as a craft item.

Pressing 'Place Items' will then move all those items to the broker same as on the Sale tab..


This is still work in progress , there are a few parts of these functions I'm not 100% happy with but it's fully working and almost there.
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.14 : released 13th August 2009

I decided enough code had been changed to up the version numbers 8)


The method of defining where you want the crafted items automatically placed has changed fairly majorly.

The Craft and Inventory tabs no longer have a text box to enter the broker box number in.

Instead , for each broker box you have there is a selection Pulldown , the options are Place , Primary and Ignore.

When placing an item on the broker.

Primary makes the script fill up that box first , you can only have ONE primary box.
Place makes the script fill up these boxes once the Primary box is full.
Ignore makes the script totally ignore that box when looking at what box to fill up next with the item.

Because of the major code change , you need to go into your craft Tab and re-set up all your 'Primary' boxes per item then hit save
after setting up each items box.

This partly came about because you cannot place 'Field Repair Kits' in a carpenters Furniture Sale Container , so you can now
block off containers that you know an item will not fit in to.
 

mycroft

Script Author: MyPrices
Version 0.14a : released 15th August 2009

When running the Place routine for crafted items , the script will now automatically mark a container as Ignore when attempting to place an item in a container that it cannot go into.

Once done it will then re-scan for available containers and re-attempt to place the item in the new broker container.
 

mycroft

Script Author: MyPrices
Version 0.14b

Re-added the Primary Box text entry box to the Inventory and Craft Tabs as some people like that type of system better.

It basically just changes the pulldown listbox of the number you enter to be Primary.

Fixed a minor cosmetic text bug on the inventory and craft tabs.
 

mycroft

Script Author: MyPrices
Version 0.14c : released 31st August 2009

Script went through some MAJOR reworking , reduced the number of variables I used and cleaned up the script a fair bit.

All functions have been tested and still work as they should...if you find any errors , please let me know.


** There IS more script cleanup work to be done sometime in the near future **


Added a filter to the Inventory Tab , enter a phrase or word and press rescan , only the items in your inventory that match that filter will be shown in the list.

Click on an item in your Broker list on the Sell tab and the script will show how many of those items you have on the broker (includes all those items in all boxes)
 

mycroft

Script Author: MyPrices
Version 0.14d : released 2nd September 2009

Collection items come to the Myprices Buy Tab.

You can now set the script to look for UNCOLLECTED collection items.

Click on the Collection tickbox , enter a partial name or no name at all and the max price you will pay and myprices will scan and buy those collection items for you.

Remember to click on the entry you have just typed in to make sure it's looking for what you want before you leave it to scan on it's own.
 

mycroft

Script Author: MyPrices
Version 0.14e : released 3rd September 2009

Fixed several bugs to do with buying collection items.

1. Duplicate items won't be bought when the name has a comma in it.
2. Fixed the Item Number Counter not decreasing when buying collection items.
3. Went through the script and finally squashed ALL errors to do with item names having commas in them.

The script now keeps track of collection items that have been checked and found to be already collected , it will from then on skip them on the broker , this has more than tripled the speed of scanning for new collection items.
 

mycroft

Script Author: MyPrices
Version 0.14f : released 4th September 2009

Bugfix : Collection items list is now cleared between character scans.

Addition : The Already Collected Collection items list per server/charname is now saved when the script exits and reloaded on startup.
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.14g : released 4th September 2009

1. Added The Maximum Spend option under the Buy Tab , you can now set a maximum coinage you are willing to spend when buying multiple items under a Buy Entry (e.g. collection items / raws / mutables)

Once that limit is reached the script will stop and move onto the next entry , even though you haven't bought the number of items you set.

If you don't set a value the script will auto-fill it with the (Number of Items * the Max Price you want to pay per item)

2. Locked down all the buttons on the UI so they cannot be clicked while the script has a scan running (Did it this by accident on the Buy Tab while running a large test of the new buy routines , the result was...interesting.)
 
Last edited:

mycroft

Script Author: MyPrices
Version 0.14h : released 5th September 2009

1. Fixed a bug where the maximum spend would be calculated automatically instead of taken from the values you entered.
2. Added a pause to wait till the examine window appeared when scanning for collection items , hopefully should help when you have lots of lag.
3. Added more checks for the mouse being over the broker window to the buy routine , should stop errors with items being skipped or bought when they shouldn't be.
 

mycroft

Script Author: MyPrices
Version 0.14i , Released 10th September 2009

Version 0.14i , Released 10th September 2009

1. New item on the Admin TAB , Items Not for Sale checkboxes.

If you do not want items in certain inventory containers to be scanned for craftable items when using the Place or 'Craft' buttons you now need to check the box next to the container name , this is a workaround for the 'itemsnotforsale' not working bug , I'll probibly just leave this as it is from now on.

The boxes are shown in the order they are in your characters inventory.

2. Hopefully finally fixed the Collections routine to stop the 'already' collection items list being cleared.
 

mycroft

Script Author: MyPrices
Version 0.14j - Released 21st September

Script Code Upgrade Version :

Went through code and fixed some of the if/else statements to make more sense , removed all the large defined arrays and replaced them with collection variables instead.

So it won't matter in future how many items you have on the broker , there will be no limit to the number of items the script can deal with (was 1000 max previously).
 
Status
Not open for further replies.
Top Bottom