Discussion Thread for Price Check

[mycroft]

Issue I have noticed since updating to .11

If you set a Min Price and run the script. It wont update a new min price in the file.

strange , works here but I'll re-check..Are you hitting 'Save' after changing the price? , I just tried it here with several items in the list and it works 100%.

Also could you use a Folder structure like EQ2MyPrices so we can keep all the
script files in one place like craft does.

Ok , I'll look into doing that once I've fixed any bugs in the code..

I found if you change the price by silver it works. But it isn't changing copper at all.

Which value? - you mean Min Price?

Trying to use the craft favorite feature. It looks as though Myprices only makes a CHAR_myprices file and dosen't append the data file used by craft. Are you working with Blazer to add a possable switch to craft?
IE /craft myprices so it will load the myprices xml? Or are we just going to have to copy it manually? Having it append the current file would be great.

I found the problem...it was writing to the wrong file..Fixed in new version in the SVN

/craft myprices does load the list and start crafting automatically already 8)

 

[Syliac]

Which value? - you mean Min Price?

Yes If you adjust the MIN price by copper it wont update.

 

[mycroft]

Yes If you adjust the MIN price by copper it wont update.

I still can't reproduce this , I've changed every single minimum price in my list PP,GP,SP and CP and if I hit the save button it always saves the values.

Is anyone else having this problem ?

 

[mycroft]

Posted a small SVN update today...

download the latest version and manually move your character.xml files from

/scripts/XML/ to /scripts/EQ2MyPrices/XML/

this will be the last file movement update...I promise...

 

[Pygar]

Hmm, new version for me just keeps switching between my two merchant boxes and never cycles down the item list and sets prices...

 

[mycroft]

Hmm, new version for me just keeps switching between my two merchant boxes and never cycles down the item list and sets prices...

I have a new version which I was adding a harvest checkbox under the buy tab so it would buy a max of 200 instead of 100 , I've added a log option to it (still adding extra log lines right now)

It will log which functions are being called with what data and whats returned , hopefully running this with logging turned on and PMing me with the log file might give me an insight to whats going wrong.

I'll update the SVN when it's finished.

 

[mycroft]

Version 0.11c

New option on the Buy Tab , harvest checkbox , clicking this when editing the item you want to buy will tell the script that the max stack size that can be bought for this item is 200 not 100.

Logging : some people are having problems with the script not working properly (I can't duplicate the problems here yet)

There is a new logging checkbox , run the script , check this box , exit the script and re-run the script..run the scan as normal and when
it's finished uncheck the textbox..

The log file can be found inside the EQ2MyPrices folder , PM me this file and I can see what functions are being called and
what information is being passed/returned.

Hopefully this will give me some insight to whats going wrong and where.

If need be I'll add more logging inside each function using smaller updates till we narrow it down...

 

[mycroft]

Anyone else having any problems with the script before I start adding more to it?

 

[bjcasey]

Is there a way to reset the craft log? It imported my craft log great the first time, but now it continually asks to craft the same items over and over even though that number would put me way over the stock number I entered.

 

[bjcasey]

It appears that closing the eq2 session will wipe the craft log properly. My suggestion would be to make a clear log button on the craft tab to click on before you transfer the new log.

 

[mycroft]

It appears that closing the eq2 session will wipe the craft log properly. My suggestion would be to make a clear log button on the craft tab to click on before you transfer the new log.

I did a SVN update a couple of days back that fixes this , the old craft log is wiped before the new one is made....or it should be.

 

[gtwo]

Im having a buying issue. Items are spelled right, Prices are set, quanities are set to 100. But it doesn't buy the items. It scans the market perfect, but will not buy anything.

 

[mycroft]

Im having a buying issue. Items are spelled right, Prices are set, quanities are set to 100. But it doesn't buy the items. It scans the market perfect, but will not buy anything.

I did some checking and found the problem, I've released a new version in the SVN that fixes the problem with buying not working..

Thanks for letting me know.

 

[gtwo]

Sorry i didnt get a log back to you before you didi the research.....But thanks for fixing gonna try it now

edit:
Perfection...Works great Thanks

 

[Syliac]

Suggestion

I request that you add:

Actor[nokillnpc]:DoTarget
wait 1
Target:DoFace
wait 1
Target:DoubleClick
wait 10

to the beginning of the main function this will automatically open the broker.

Sy-

 

[mycroft]

Taken a break from coding this for the christmas break , but I'm back now...working on a few things , specifically loading up craft items on the broker automatically.

The non-specific name search is working (Master 1's between level x and y below z gold etc) but only as a click on the search box , I added it as a normal buy search , but people started adding things like master rez items or conjuror shards and putting them up for sale , so I've decided not to add it to the normal buy routine.

You can still click on the entry in the buy list and that will list them all on the broker.

 

[wired203]

mycroft great script, I did a SVN update a few days ago so I am running the most current version but I have hit a issue. The craft list will copy over from each char that has been logged in so it appears that the variables for creating the xml isn't being cleared from memory when you quit, perhaps on the script load you should null out the values?

Here is a example, char 1 is a scribe, has 5 spells in his craft list. Char 1 logs in and runs myprices etc. Char 2 is a alchemist, char 2 logs in and runs myprices and under his craft tab is every line Char 1 had, say all 5 spells again.

Now log out of eq2, unload lavish, re-load lavish, start eq2 again and you finally have it load and work right for the 1st char only. Load in your 2nd char and watch the list just populate everything from char1.

Thanks for any help on this.

 

[mycroft]

mycroft great script, I did a SVN update a few days ago so I am running the most current version but I have hit a issue. The craft list will copy over from each char that has been logged in so it appears that the variables for creating the xml isn't being cleared from memory when you quit, perhaps on the script load you should null out the values?

Here is a example, char 1 is a scribe, has 5 spells in his craft list. Char 1 logs in and runs myprices etc. Char 2 is a alchemist, char 2 logs in and runs myprices and under his craft tab is every line Char 1 had, say all 5 spells again.

Now log out of eq2, unload lavish, re-load lavish, start eq2 again and you finally have it load and work right for the 1st char only. Load in your 2nd char and watch the list just populate everything from char1.

Thanks for any help on this.

Hmm...I'll check that out , it's 'supposed' to be cleared each time...

I've updated the script to do a few more clears , hopefully should solve that.

 

[wired203]

By craft list I am referring to your craft tab, and not the output file that goes into craft. course it doesn't see any stock and wants to make everything on the wrong chars hehe.

 

[mycroft]

By craft list I am referring to your craft tab, and not the output file that goes into craft. course it doesn't see any stock and wants to make everything on the wrong chars hehe.

Yes , those settings are saved as part of the item list for each character..

With the new changes only the settings for that character will be saved , unfortunately any existing settings will be kept , I'll do something so you can unselect them as craftable items from the craft list tab.


Version 0.11f Rev 3
-------------------

Added a button to let you unset an item in the craft tab , select the item in the list and press Unset , the item will be
unmarked as a craft item and the list will refresh.

Fixed a bug where items marked as craft items on one character were also being saved as craft items on another.

Several Minor bigfixes.

 

[wired203]

Mycroft many thanks works great now. The buttons are a little small for the average user may want to make those 2 a hair bigger. I just directly edited the XML for cleanup and to get everything going good and now my chars have a MyStore hehe.

 

[Voltstorm]

Seems to not be working post GU42

 

[Amadeus]

Things should be working now as of version 20080206.0032. If not, I need to know about in a bug report (with what is specifically not working.)

 

[Syliac]

Request

A request I have if possable is to omit a broker bag from the scans.

Thanks

 

[mycroft]

A request I have if possable is to omit a broker bag from the scans.

Thanks

Added tickboxes for each box/bag , if it's ticked it will scan , if not it skips...


Codes not released yet to the SVN yet , I'm still working on the code to put crafted items on the broker automatically..

I'll release that when I've completed this also.

 

[wired203]

That's a nice addition, Mycroft I wanted to take the time to personally thank you for all the hard work you have put into this script. You really listen to requests and find a way to make them happen. Thank You.

 

[mycroft]

Revision 5

Latest version uploaded to the SVN with the option to do a more 'natural' scan of your broker contents.

Next version will also have an option to camp your character after a set time if you use the continual scan feature.

 

[Syliac]

Thanks for adding that it it rocks.

:toast:

 

[kumpel100]

Craft list problem !

anyone can help to to get the craft recipe part to work on myprices? i all time get in Craft a full list of my "craft" items and not only the missing parts in my shop.

<Set Name="Pristine Imbued Merchantine's Bloomers">
			<Setting Name="Sell">100.000000</Setting>
			<Setting Name="MinSalePrice">TRUE</Setting>
			<Setting Name="CraftItem">TRUE</Setting>
			<Setting Name="Stack">1.000000</Setting>
			<Setting Name="Stock">1</Setting>
		</Set>

so looks an item in myprices.xml
if its sold or not it shows all time into myprices craft list.
ty


EDIT: it works i was not belive that i have alot items set to Craft item !

 

[Flappy]

MyPrices seems to not be able to handle items with commas in the names. A lot of the collectible book names have commas in them, and the item name is cut in the MyPrices UI when scanning the broker for items to sell. As a result, it can't pick the proper name to price against. Is it possible to use another delimiter besides comma? Just wondering.

Edit: Posted in bug report section with more details.

 

[mycroft]

MyPrices seems to not be able to handle items with commas in the names. A lot of the collectible book names have commas in them, and the item name is cut in the MyPrices UI when scanning the broker for items to sell. As a result, it can't pick the proper name to price against. Is it possible to use another delimiter besides comma? Just wondering.

Edit: Posted in bug report section with more details.

Can you type a few examples , I'm sure I can work around it..

 

[wired203]

Hey if your working on comma issues, apostrophe in food recipies causes craft to not parse correctly. Load up a provisioner, setup a store with screewoogans surprise, there's a ' there somewhere. And it doesn't parse correctly into the craft list.

 

[speedycerv]

My myprices isn't changing the prices for my other items in the box. I have 2 items in the box and it will match the first one, and for the 2nd item in my box it doesn't search. It will just set the price for the adept and then leave the fulginate untouched. If i check everything off, it will keep scaning for the first item over and over and never scan for the 2nd one, any idea what the problem is i'm having?

 

[mycroft]

Can you type a few examples , I'm sure I can work around it..

Comma issues is a problem with extra parsing in Innerspace when reading a textbox , currently there is no way around it.

 

[mycroft]

My myprices isn't changing the prices for my other items in the box. I have 2 items in the box and it will match the first one, and for the 2nd item in my box it doesn't search. It will just set the price for the adept and then leave the fulginate untouched. If i check everything off, it will keep scaning for the first item over and over and never scan for the 2nd one, any idea what the problem is i'm having?

Are you using the 'natural' scan option , what options are you using?

 

[mycroft]

Hey if your working on comma issues, apostrophe in food recipies causes craft to not parse correctly. Load up a provisioner, setup a store with screewoogans surprise, there's a ' there somewhere. And it doesn't parse correctly into the craft list.

Is the recipie name and the item name the same or do I need to put in a way to read the Customwrits list to change the name ?

I have a sneaking suspicion that this is a similar innerspace problem to the comma which will need Ama to make some changes.

 

[wired203]

the CustomWrits actually has that particular recipie in there as a sample. or at least it did. If you don't see it I can pull it from mine later this evening.

 

[speedycerv]

I was using the natural scan option, and tried it without it, and it seems to be working better

 

[mycroft]

I was using the natural scan option, and tried it without it, and it seems to be working better

Ok , I'll check that scan code

 

[mycroft]

the CustomWrits actually has that particular recipie in there as a sample. or at least it did. If you don't see it I can pull it from mine later this evening.

Is the item name and recipe name the same? , trying to figure out if it's an innerspace/script truncation problem or just a recipe one...

 

[mycroft]

Ok , I'll check that scan code

Quick fix and natural scan should now scan all items in the list , though with only 2 items on the broker it's not really worth using that option tbh.

 

[mycroft]

Is the item name and recipe name the same? , trying to figure out if it's an innerspace/script truncation problem or just a recipe one...

Revision 7 in the SVN now has an extra box in the craft tab for each item where you can put an 'alternative' recipe name to be sent to the craft file.

 

[speedycerv]

Even without natural scan on, for the last item in my lists when changing prices, it never is scaned/changed prices. this is with multiple items aswell, always just the last item doesnt get scanned.
edit: odd, it changed after i finished writing this post... maybe it just very delayed?

 

[nilsar]

myprices

is there a way to put in where you can say cut the price matched my 1 gold thus making your price lower then rest?

 

[mycroft]

is there a way to put in where you can say cut the price matched my 1 gold thus making your price lower then rest?

No , I won't add this option.

Mainly because if you have 4 or 5 scripts doing this prices will drop like a stone till they reach 1 copper or the lowest possible price you will accept.

 

[mycroft]

Current status of myprices

The new version I have on my system includes the option to place all your crafted items in your inventory onto the broker automatically.

I'm currently just waiting for the update to the addtoconsignment option so they will be grouped with existing items before releasing it.


1. It goes through your craft flagged items one by one.
2. The script searches for items of the same type , if found the items are placed in that box until they are all added or that box is full.
3. If there is no (more) space in a box with the same type of item or no matching items in your broker slots, then it places the items in the box with the enough space to fit ALL those items in your inventory.
4. If no box has enough space to fit all of those items it distributes them between the boxes (filling boxes with the most space first).
5. it stops when you have no more space left anywhere.

 

[utadaishot]

Very impressive work, Mycroft.

 

[wired203]

Thanks for the new version Mycroft, finally a reason to update from the SVN as everything else I have has been working great.

 

[mycroft]

Anyone else having any more problems with myprices now after the last update to fix items being skipped?

I've had a report of items being set at a price of 0 instead of the reported price in the log window but can't duplicate it.

 

[larrydoyle]

I'm occasionally having it set items to "for sale" with a price of zero. Have not seen a pattern for it .. it seems random, and happens every 30-40 items or so.

 

[mycroft]

I'm adding more logging to see whats going on with the routines that set the actual broker prices.

Also looking at adding another check so if a price is set to 0 instead of what it SHOULD be it will do 'something' (not sure what yet).

 

[marcbrouard]

Having a few problems

Hi Mycroft, Yep having the issue were items are set to 0 price and not the one in the log. Also having the log report errors

*** ERROR - unable to mark striped green ant as listed for sale

Do not think that i have set anything up wrong, but this is the first time i have used your script. I have made sure that I have the latest version from svn

It does look like a great tool though, thanks in advance

 

[mycroft]

Update : new version in the SVN , added more logging to ensure that the script is attempting to change the price.

Hopefully should let me know if it IS the script having problems or the problem is occouring elsewhere.

Unless you are having problems with the prices being set to 0 then listed for sale , don't bother with this update.

Just in-case the script finds a price has been set to 0 then it will unlist the items to save them causing problems...

 

[mycroft]

Those reporting errors , I need to see those updated log files for items having this problem so we can help Ama determine where the the error is happening..

Another thing that would help (me also) is the location of the broker where you are having these problems with.

 

[marcbrouard]

Reported errors

Hey mycroft,

Still having a few errors with your latest update. seems only to happen on a few items though. the location is nettleville hovel. I have attached the myprices log. Although I had to cut the end of the log file off, because it was too big to upload as a text file.

Please shout if you require any more information

 

[mycroft]

Hey mycroft,

Still having a few errors with your latest update. seems only to happen on a few items though. the location is nettleville hovel. I have attached the myprices log. Although I had to cut the end of the log file off, because it was too big to upload as a text file.

Please shout if you require any more information

Thanks for the log , however , could you download the most recent SVN version as that has extra logging which shows what data is being passed to the command that sets prices..

 

[marcbrouard]

Sorry about that, thought that i had the latest version already. Made sure this time that i have download the latest version rom svn.

Not getting the error message anymore. But as your script scans through the items they are not being taken off sale. And the price is not being changed.

Although I have found that if i change the first item so it is not on sale, before i run the script everything seems to work great.

I have attached the log file from the run where it was not setting the prices. Please shout if you need anyting else.

This script is saving me a lot of work, so i am very grateful, thanks

 

[Contact]

I may be confused as to how exactly myprices works-- take a look at the two attached pictures. in picture 1, it seems as though for some reason it is setting the price 1s below the "lowest" price. It looks as though 3 or so other people on my server are using the same script and it is doing the same thing for them.

For reference, I have the first 5 button checked: auto-match lower & higher, merchant match, set prices for unlisted items, and ignore copper.

It set my sale to 69g 97s, and the next higher is 69g, 98s, next is 69g 99s, etc.

As for the second screen it looks like it's doing some sort of calculation to make mine show up as 80c cheaper on the market. It's selling that item at 4g 66s, making the price to people checking the broker in qeynos 5g, 59s, 20c. The next "cheapest" price is actually 4g, but since it's listed in Neriak it shows up on the broker as 5g 60s.

Having prices like that to me looks "suspect" and I thought that the intention was to not have myprices undercut (as per an old thread that I found on these forums.)

 

[mycroft]

Ignore copper setting is whats doing this...turn that off if you want to match prices exactly to the current lowest.

Turning it off will mean your prices will be set to (for example) 4g 65s 21c instead of 4g 65s , which I think looks more 'bot calculated' than just setting silver and gold.

It's only the added broker fee that gives you the lower price (the server itself rounds down any partial amounts on broker fees).

 

[Contact]

So I am correct in assuming that it is calculating the price so that it *appears* as the lowest price-- for instance, putting something for sale in Qeynos at 5pp will (usually) show up as 6pp at a Qeynos broker, but 7pp at a Freeport broker.

If somebody has the same item up for sale in Freeport at 5pp, I'm going to charge 5p83g33s? Is there/can there be an option just to make it MATCH the actual price?

 

[mycroft]

So I am correct in assuming that it is calculating the price so that it *appears* as the lowest price-- for instance, putting something for sale in Qeynos at 5pp will (usually) show up as 6pp at a Qeynos broker, but 7pp at a Freeport broker.

If somebody has the same item up for sale in Freeport at 5pp, I'm going to charge 5p83g33s? Is there/can there be an option just to make it MATCH the actual price?

Yes , it matches the price to the lowest one you are shown at your current broker...regardless where it's being sold from...

so if the sellers % broker fee is higher than the location you are selling from , your actual price will be higher to give the same price including broker fees.

That option , I'd have to look into it , depends what info ISXEQ2 can find from the broker.

 

[Wishbringer]

Same problem but vice versa:
I have a bag, which reduces broker fee. All item in it appear cheaper than from other vendors.

 

[mycroft]

Same problem but vice versa:
I have a bag, which reduces broker fee. All item in it appear cheaper than from other vendors.

First time I've heard of that bag...whats it called and how much does it reduce? , I already check for the 50% broker fee reduction selling item.

Oh and by how much cheaper....<on average>

 

[mycroft]

If somebody has the same item up for sale in Freeport at 5pp, I'm going to charge 5p83g33s? Is there/can there be an option just to make it MATCH the actual price?

I checked all the info I am able to get from the broker system , I am able to read an items Price , this is the actual price it is being sold for (not including commission).

i Will test it for a while and see how it works out , if there are no problems I will release a new version with this option.

 

[Wishbringer]

First time I've heard of that bag...whats it called and how much does it reduce? , I already check for the 50% broker fee reduction selling item.

Oh and by how much cheaper....<on average>

It's called "Veteranen-Vitrine" at german clients.
Not tradeable.
Reduces by 50%
You get it for 3 years of subscription

I changed your script by myself after I found the "Veteran's Display Case", but maybe you want insert name as an option

 

[mycroft]

It's called "Veteranen-Vitrine" at german clients.
Not tradeable.
Reduces by 50%
You get it for 3 years of subscription

I changed your script by myself after I found the "Veteran's Display Case", but maybe you want insert name as an option

Ok, that's easy enough to add as an OR statement to the existing script.

 

[MrObvious]

What I really like to do is undercut the lowest price by 10% or so. Would it be possible to add that calculation? Maybe put in the UI the percent you want to set the price lower than the current lowest price?

 

[wired203]

Undercutting would cause a huge market crash as there is always several people per server running mycrofts script.

Mycroft I do have a request, can we get a max price on crafted items? Some people overcharge so high for some things it's nuts and I just manually adjust those down by hand.

 

[MrObvious]

Undercutting would cause a huge market crash as there is always several people per server running mycrofts script.

Mycroft I do have a request, can we get a max price on crafted items? Some people overcharge so high for some things it's nuts and I just manually adjust those down by hand.

Sorry just read a few pages back and read that response before.

How long should the scan take to run? Mine seems to stop at "paused" for a long time.

 

[wired203]

It pauses if your mouse isn't over the broker window, isxeq2 reads broker info much better when mouse is over the broker window so mycroft put a pause in for when it's not.

If you stack your myprices window over your broker window you can still keep the mouse over the myprices window and it still see's the broker window below it.

 

[MrObvious]

It pauses if your mouse isn't over the broker window, isxeq2 reads broker info much better when mouse is over the broker window so mycroft put a pause in for when it's not.

If you stack your myprices window over your broker window you can still keep the mouse over the myprices window and it still see's the broker window below it.

Yep, that was it. Thanks. Would love a little FAQ on this script... difference between normal and natural scan, this last tip, etc.

 

[mycroft]

Yep, that was it. Thanks. Would love a little FAQ on this script... difference between normal and natural scan, this last tip, etc.

There is a readme.txt inside the EQ2MyPrices folder..explains how it works etc.

 

[mycroft]

Undercutting would cause a huge market crash as there is always several people per server running mycrofts script.

Mycroft I do have a request, can we get a max price on crafted items? Some people overcharge so high for some things it's nuts and I just manually adjust those down by hand.

I will look into adding a max price tick box and price, it'll work for everything.

 

[mycroft]

Version 0.12g

Added an option to sell at the same price as the lowest price on the broker (ignoring the sellers broker fee)

If you sell on the Freeport broker and someone in Qeynos is selling an item for 25g without commission then your same item will be set to 25g also.

It will appear on the Freeport broker as cheaper than the one for sale in Qeynos, but still show as more expensive to people scanning the Qeynos broker due to higher broker charges.

SVN has been updated.

 

[mycroft]

version 0.12h

Added an option to set a maximum price to sell each item for.


SVN has been updated.